search

thedodd / wither

An ODM for MongoDB built on the official MongoDB Rust driver.
https://docs.rs/wither
Other
324 stars 40 forks source link

Upgrade client #86

Closed simoneromano96 closed 2 years ago

simoneromano96 commented 2 years ago

This is a first version that just wraps the generic T argument for the documents with Document.

I don't think that this should be THE permanent solution but this surely is a first step.

Tokio is growing in popularity so with this PR we should be ready and doesn't require any user intervention for upgrading.

Since this is a breaking change (upgrading tokio) we need nevertheless a major version.

@thedodd , what do you think?

The related T type for the Collection/Cursor has been implemented in:

ndelvalle commented 2 years ago

Is this PR still WIP? I would like to contribute to upgrade the Mongo version, so we can use Tokio v1.

simoneromano96 commented 2 years ago

Is this PR still WIP? I would like to contribute to upgrade the Mongo version, so we can use Tokio v1.

It should work, I'd like a code review before merging

Edit: I actually need the approving review of @thedodd to merge this