search

thedodd / wither

An ODM for MongoDB built on the official MongoDB Rust driver.
https://docs.rs/wither
Other
324 stars 40 forks source link

Bring project back up to speed #89

Closed ISibboI closed 2 years ago

ISibboI commented 2 years ago

Thank you for making this amazing project! I would like to use it in my own project, however it appears that it uses an outdated version of the mongodb driver that in itself depends on an outdated version of tokio which is incompatible to newer versions.

I updated the mongodb driver to the newest version, added mongodb 5.0 to the tests, and set tokio to the newest version in the dev dependencies to ensure that the crate is now compatible with tokio 1.x.

Further I formatted the code and fixed all lints, such that all integration tests pass.

There are a few breaking changes, including adding type parameters to traits because the interface of the mongodb driver changed slightly.

I would be happy if you could release this pull request, such that I can use wither in my code soon :)

simoneromano96 commented 2 years ago

Hello, I'll review asap, probably by tomorrow evening.

I should be able to merge other people's PRs

simoneromano96 commented 2 years ago

LGTM

I think we should merge this, then update the docs and finally write a changelog.

ISibboI commented 2 years ago

Thank you very much!

thedodd commented 2 years ago

@ISibboI thanks for the PR and @simoneromano96 thanks for the review and merge! Very happy to see this :)

ndelvalle commented 2 years ago

@thedodd @simoneromano96 can we make a release with these changes please <3

simoneromano96 commented 2 years ago

@thedodd @simoneromano96 can we make a release with these changes please <3

Hi, so currently I'm not able to push on master, locally I've updated the changelog to prepare the release however I cannot tag to create a new release