search

thedodd / wither

An ODM for MongoDB built on the official MongoDB Rust driver.
https://docs.rs/wither
Other
324 stars 40 forks source link

Replace redundant trait bounds with Model #90

Open ISibboI opened 2 years ago

ISibboI commented 2 years ago

This is as discussed in #89.

I replaced the bounds of the form Model + X with just Model. In the Model trait I wrote a sentence of documentation explaining why the additional trait bounds are needed.

In the ModelCursor struct, instead of writing out the bounds required for Cursor, I restricted the whole struct to Model. That made sense to me, because a ModelCursor seems to be designed to be used with a Model.

I also removed the PhantomData from ModelCursor, since the generic type T is now used in the Cursor.

I additionally added a few characters of documentation stating that we now also test against mongodb 5, and I ran cargo update.

ISibboI commented 2 years ago

Could you merge this and publish it to crates.io? Even doing something like a 0.10.0-alpha.0 would be great already :)

chumaumenze commented 2 years ago

Will this be merged? When will this and https://github.com/thedodd/wither/pull/89 be released?