Migration to yew 0.18.0

thedodd / ybc

A Yew component library based on the Bulma CSS framework.

Apache License 2.0

258 stars 37 forks source link

Migration to yew 0.18.0 #20

Closed Pscheidl closed 3 years ago

Pscheidl commented 3 years ago

Makes the components usable with Yew 0.18.0

release workflow

We follow semver for versioning this system.

[x] update Cargo.toml version.
[ ] ensure CI completes successfully.
[ ] add a new tag to the repo matching the new Cargo.toml version. Either via git tag or via the Github UI.
- all release tags should start with the letter v followed by a semver version.
[ ] CI is configured for release tags and will create a new Github release.
[ ] once CI for the tag has finished successfully, update the new release page with details on the changes made, which should reflect the content of the CHANGELOG.md.

ppiotr3k commented 3 years ago

:question: @thedodd anything preventing from launching the CI workflow and moving forward on this PR? :pray:

Not being able to work using Yew 0.18 is personally a great pain, especially as Yew Documentation only addresses 0.18 now, that Yew Router has been greatly improved to work with it, etc.

thedodd commented 3 years ago

@ppiotr3k hey there. Just as a quick note to address timing, you don't actually need to wait for an official release to go out. You can have your Cargo.toml point to the forked source. That way you can immediately start using the updated code.

Pscheidl commented 3 years ago

@ppiotr3k ybc = { git = "https://github.com/Pscheidl/ybc/", branch= "yew-0.18.0" }

Pscheidl commented 3 years ago

@thedodd Clippy righteously complained about duplicated clones. Corrected.

ppiotr3k commented 3 years ago

@thedodd @Pscheidl thanks for both your replies :bow:

Actually I figured out there are uncovered changes from moving to Yew 0.18 in @Pscheidl's branch - which in all cases helps moving forward in upgrading to Yew 0.18. I therefore started PR #21 in order start having some tests, with the idea to ease on the upgrade path.

While #21 just proposes a starting point, leveraging existing Rustdoc examples for tests, it already shows IMHO a few other required fixes due to changes in Yew 0.18. I have already started more Rustdoc examples, to both increase documentation and provide test material, but I'm awaiting feedback on #21 to ensure this is an effort worth being taken :slightly_smiling_face:

Pscheidl commented 3 years ago

@thedodd Waiting for CI to be ran. Thank you.

Follpvosten commented 3 years ago

What's going on here? I'd like to upgrade to 0.18 soon and I don't really want a git dependency or my own fork (although I'm considering it)

thedodd commented 3 years ago

Disregard, I'll address the linting issues separately :). Cheers mate!

Pscheidl commented 3 years ago

Ok, thank you @thedodd. Yup, that was it. I didn't check those details to be honest. I'm on 1.53 and I just use rustfmt automatically.

Thanks you.