search

thedudeguy / JukeIt

A Bukkit plugin for Minecraft that allows you to "Burn" new music onto Music Discs and play them in the Jukeboxes.
GNU General Public License v3.0
10 stars 10 forks source link

Burning blank urls #63

Closed spathizilla closed 12 years ago

spathizilla commented 12 years ago

With JB 1.12.1 (and on 1.13 pre) on cb 1337:

if you hit the burn button without entering any URL, it still burns the disc as a blank url. I think this should be a special condition where the disc doesnt actually burn and is returned as blank. Some people might click the burn button with a blank url thinking it would cancel (rather than hitting escape).

thedudeguy commented 12 years ago

hmm. ya alright.

spathizilla commented 12 years ago

It is a very minor issue and I'll probably never do it again. But, I did click burn without thinking while testing 1.12.1 with the blank url and had a wtf moment. Shouldnt be more than like 3-4 lines of code anyway.

spathizilla commented 12 years ago

It also might be worth blocking nonplayable urls at the burning stage. Otherwise you just get warned when you try to play

spathizilla commented 12 years ago

I did it myself..

thedudeguy commented 12 years ago

Feel free to make a pull request if you like.

thedudeguy commented 12 years ago

scratch that, i just learned about the fork queue :D