theduke / quickjs-rs

Rust wrapper for the quickjs Javascript engine.
MIT License
570 stars 48 forks source link

Undefined references #129

Open AtomicFS opened 8 months ago

AtomicFS commented 8 months ago

I have been trying to compile a new release of mdbook-katex which is using quickjs-rs, but ran into problems. TLDR: opened and issue and got forwarded here.

When trying to compile, I am getting a lot of undefined references.

Could this have something to do with quickjs getting maintained again? They just made 2 new releases relatively recently (2023-12-09 and 2024-01-13).

Downgrade of quick-js to v0.4.0 fixes the problem.

theduke commented 8 months ago

So I assume you have quickjs installed on your system, and the bundling feature of the crate is not enabled?

In that case there would be a mismatch between the expected API and the actual new API.

AtomicFS commented 8 months ago

As far as I can tell, I do not have it installed. This also happens in my CI/CD pipeline where I have bare minimum of software installed.

AtomicFS commented 8 months ago

Is there anything else I could provide?

SichangHe commented 7 months ago

So I assume you have quickjs installed on your system, and the bundling feature of the crate is not enabled?

katex-rs uses the patched feature of quick-js, if that information helps:

https://github.com/xu-cheng/katex-rs/blob/1bc50c3ad641a38f81e827b6f315ffeb3d4f6b03/Cargo.toml#L23

AtomicFS commented 6 months ago

Even running cargo build --all-features --release does not help, if that is what you are asking.