thedyze / save-image-extended-comfyui

Extended Save node for ComfyUI
82 stars 6 forks source link

Error object of type 'NoneType' has no len() #1

Closed jimmiles closed 12 months ago

jimmiles commented 1 year ago

How to use this to make it save to a folder named for the date? ComfyUI has a built-in node to do this. I thought this node would use that syntax (%date:yyyy-MM-dd%). Or am I doing something wrong? Also thought this would help me choose a path. I can't believe how so many other UIs find path customizing trivial, but ComfyUI left out any easy way to choose image save path setting. Shouldn't it be in the Main settings menu? Anyway, I digress.

Error occurred when executing SaveImageExtended:

object of type 'NoneType' has no len()

File "E:\ComfyUI_windows_portable\ComfyUI\execution.py", line 152, in recursive_execute output_data, output_ui = get_output_data(obj, input_data_all) File "E:\ComfyUI_windows_portable\ComfyUI\execution.py", line 96, in get_output_data output_is_list = [False] * len(results[0])

thedyze commented 1 year ago

To achieve this, add a 'Get Date Time String' node. Then inside the Save Image Extended node, right click and choose 'convert foldername_prefix to input'. Finally, drag the output of the date node to the new input. Should also work for 'filename_prefix'. Let me know if it doesnt work as expected.

jimmiles commented 1 year ago

I found a better way buried in an issue discussion: " You can now use --output-directory directory/path to set the output path." https://github.com/comfyanonymous/ComfyUI/issues/96

On Thu, Oct 5, 2023 at 12:56 PM thedyze @.***> wrote:

To achieve this, add a 'Get Date Time String' node. Then inside the Save Image Extended node, right click and choose 'convert foldername_prefix to input'. Finally, drag the output of the date node to the new input. Should also work for 'filename_prefix'. Let me know if it doesnt work as expected.

— Reply to this email directly, view it on GitHub https://github.com/thedyze/save-image-extended-comfyui/issues/1#issuecomment-1749310637, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACOLZNMX2I5QHMYOBFL7VLLX53RDLAVCNFSM6AAAAAA5UKIALGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBZGMYTANRTG4 . You are receiving this because you authored the thread.Message ID: @.***>

thedyze commented 1 year ago

Glad you found something that works for you. Though reading through the discussion, the --output-directory method doesn't seem to work that well for some of the users.

Den fre 6 okt. 2023 kl 13:05 skrev Jim Miles @.***>:

I found a better way buried in an issue discussion: " You can now use --output-directory directory/path to set the output path." https://github.com/comfyanonymous/ComfyUI/issues/96

On Thu, Oct 5, 2023 at 12:56 PM thedyze @.***> wrote:

To achieve this, add a 'Get Date Time String' node. Then inside the Save Image Extended node, right click and choose 'convert foldername_prefix to input'. Finally, drag the output of the date node to the new input. Should also work for 'filename_prefix'. Let me know if it doesnt work as expected.

— Reply to this email directly, view it on GitHub < https://github.com/thedyze/save-image-extended-comfyui/issues/1#issuecomment-1749310637>,

or unsubscribe < https://github.com/notifications/unsubscribe-auth/ACOLZNMX2I5QHMYOBFL7VLLX53RDLAVCNFSM6AAAAAA5UKIALGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBZGMYTANRTG4>

. You are receiving this because you authored the thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/thedyze/save-image-extended-comfyui/issues/1#issuecomment-1750417606, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARF2J4OAOCCXIUHDCRM46JTX57QV7AVCNFSM6AAAAAA5UKIALGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJQGQYTONRQGY . You are receiving this because you commented.Message ID: @.***>

thedyze commented 1 year ago

Or were you referring to the screenshot at the bottom?

jimmiles commented 1 year ago

https://github.com/comfyanonymous/ComfyUI/issues/96#issuecomment-1636796076

No, a comment midway. It works for me so far.

On Fri, Oct 6, 2023, 1:51 PM thedyze @.***> wrote:

Or were you referring to the screenshot at the bottom?

— Reply to this email directly, view it on GitHub https://github.com/thedyze/save-image-extended-comfyui/issues/1#issuecomment-1751187105, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACOLZNO2U5W7PRHO3Q5NGKTX6BAJNAVCNFSM6AAAAAA5UKIALGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJRGE4DOMJQGU . You are receiving this because you authored the thread.Message ID: @.***>

vootox commented 10 months ago

I have the same problem though mine is I can't find the 'Get Date Time String' custom node, I also don't know what 'JPS' is.