search

thedyze / save-image-extended-comfyui

Extended Save node for ComfyUI
66 stars 6 forks source link

[BUG?]: Checkpoint name has a leading underscore #15

Open Woisek opened 6 months ago

Woisek commented 6 months ago

I addressed that a long time ago on reddit, but it's still here: When using ckpt_name, the the checkpoint name gets a leading underscore, i.e. "_realistic_vision_v5.1_SD1.5" It would be nice if this won't happen. Also, I wonder if there is a list on what tokens we could use as placeholder, like ckpt_name, seed, steps, sampler, cfg, etc. ...

Thanks for this great save node. 👍

Woisek commented 2 months ago

This problem still exists ... any idea when or even if it will be addressed ... ? 😐

audioscavenger commented 2 months ago

i fixed it here, update your comfy manager

Woisek commented 2 months ago

i fixed it here, update your comfy manager

Have to say, that it's not fixed for me. Still adds the underscore to the beginning. 😐 FK8OWUFAak The left is a new added node after update, the right an 'old' existing one.

audioscavenger commented 1 month ago

again, this is fixed. you are probably 15 versions behind. this repo is abandonned anyway.

Woisek commented 1 month ago

again, this is fixed. you are probably 15 versions behind. this repo is abandonned anyway.

Okay, but your 'fixed' version doesn't work at all.

Traceback (most recent call last): File "V:\AI_programms\ComfyUI\nodes.py", line 1866, in load_custom_node module_spec.loader.exec_module(module) File "", line 883, in exec_module File "", line 241, in _call_with_frames_removed File "V:\AI_programms\ComfyUI\custom_nodes\save-image-extended-comfyui__init__.py", line 14, in from .save_image_extended import NODE_CLASS_MAPPINGS, NODE_DISPLAY_NAME_MAPPINGS File "V:\AI_programms\ComfyUI\custom_nodes\save-image-extended-comfyui\save_image_extended.py", line 14 version = 2.6.5 ^^ SyntaxError: invalid syntax

Cannot import V:\AI_programms\ComfyUI\custom_nodes\save-image-extended-comfyui module for custom nodes: invalid syntax (save_image_extended.py, line 14)

So what about that then?

audioscavenger commented 1 month ago

So what about that then? very sorry yes, i forgot 2.6.5 is not a float number... i fixed it immediately but somehow you got the bug just before i pushed!