search

theelous3 / asks

Async requests-like httplib for python.
MIT License
509 stars 63 forks source link

Currently supports trio's development branch #154

Closed jean closed 4 years ago

jean commented 4 years ago

The README says:

Note: Currently supports trio's development branch. You can install this by doing pip install git+https://github.com/python-trio/trio.git

Is that still true? That was written two years ago and trio has had many releases since then.

carlbordum commented 4 years ago

related: https://github.com/theelous3/asks/issues/31.

It should no longer be the case. I am not at my pc atm, so I cannot verify. The README should be updated though, as that is misleading

Good catch :+1:

jean commented 4 years ago

Well I can confirm that the current trio release does support async file I/O.

On Thu, 12 Dec 2019, 21:58 Carl Bordum Hansen, notifications@github.com wrote:

related: #31 https://github.com/theelous3/asks/issues/31.

It should no longer be the case. I am not at my pc atm, so I cannot verify. The README should be updated though, as that is misleading

Good catch 👍

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/theelous3/asks/issues/154?email_source=notifications&email_token=AAAUWQHOHF7GECTGJQGZXODQYJGP5A5CNFSM4JZZERU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGW5UFY#issuecomment-565041687, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAUWQDV4OX6RKR2IRPUDWDQYJGP5ANCNFSM4JZZERUQ .