search

theelous3 / asks

Async requests-like httplib for python.
MIT License
508 stars 63 forks source link

Oon trio, we need to call sock.aclose. #69

Closed miracle2k closed 6 years ago

miracle2k commented 6 years ago

This was done in at least one case before, but that code was removed in 04b2d037130a1a6dc5e19766025c2e1c8ad5cf5b - not sure why, for me, on trio, it is still necessary.

theelous3 commented 6 years ago

I handled this in multio, one of asks's dependancies. You need to update your multio :)

Appreciate the thought though!

We alias .aclose to .close

https://github.com/theelous3/multio/commit/11b64ac68d5ecae76302ea54305b3b46d5ab402c

Side note, is there a way to force dependencies to update when you update? Idk.