theengs / app

Theengs mobile application to read BLE sensors and push data to an MQTT broker
https://app.theengs.io
GNU General Public License v3.0
37 stars 7 forks source link

Correct abbreviation for minutes in settings #11

Closed DigiH closed 2 years ago

DigiH commented 2 years ago

Correct abbreviation for minutes in settings

I know this is a fine detail, and I'm sure no user would think the Update Interval setting shows a certain amount of metres, but being an application which in the widgets shows mainly scientific data for sensors I think it would be good form to also have the correct units displaying in other parts of the app.

Before

minutesOLD

After

minutesNEW

Fine on macOS even with the maximum interval setting of 360 min, but needs checking on all other platforms, if it might not require a wider selection box, or possibly even just the number in it and a changed text label like "Update interval in min/minutes"

https://github.com/theengs/app/actions/runs/2556733375

Checklist:

1technophile commented 2 years ago

Thanks

1technophile commented 2 years ago

@emericg do we need to check this kind of modifications on all platforms or will the component resize adequately?