search

theengs / app

Theengs mobile application to read BLE sensors and push data to an MQTT broker
https://app.theengs.io
GNU General Public License v3.0
37 stars 7 forks source link

macOS build should have "About Theengs" and "Preferences ⌘," menu items #14

Closed DigiH closed 1 year ago

DigiH commented 2 years ago

Nothing major, but again going a long way in making the macOS build appear Mac like and adhering to macOS standards, it should have

About Theengs

Preferences ⌘,

on top of the current application menu items

Screenshot 2022-06-28 at 14 48 09

These menu entries are the minimum of every single macOS application, and even Microsoft themselves adhere to that rule with every of their macOS applications.

Screenshot 2022-06-28 at 15 00 50

Surprisingly enough, the Preferences keyboard shortcut ⌘, is already working and implemented in

https://github.com/theengs/app/blob/development/qml/DesktopApplication.qml#L299

and from reading

https://doc.qt.io/qt-6/qkeysequence.html

this Preferences StandardKey is a macOS only implementation already.

So adding these two menu items would only additionally require that the About Theengs would also go to/open appContent.state = "About" and the menu would look totally familiar and as expected to every macOS user.

emericg commented 1 year ago

Can you have a look at the latest macOS versions? There is an app menu now.

DigiH commented 1 year ago

Verified with 1.1 as addressed. Closing.