Small typo fixes and proposal for ellipsis

theengs / app

Theengs mobile application to read BLE sensors and push data to an MQTT broker

https://app.theengs.io

GNU General Public License v3.0

37 stars 7 forks source link

Small typo fixes and proposal for ellipsis #31

Closed DigiH closed 1 year ago

DigiH commented 1 year ago

Small typo fixes and proposal for using dedicated ellipsis character

Checklist:

[x] The pull request is done against the latest development branch
[x] Only one feature/fix was added per PR and the code change compiles without warnings
[x] I accept the DCO.

emericg commented 1 year ago

Grammar looks good (probably ^^) Regarding the ellipsis, while I really don't care, what I can tell you is the next person that will do anything in the app or in the documentation won't be instinctively using them... Like the 3/4 space spaces or the single character for ℃, these things are invisible to anyone not looking for them.

DigiH commented 1 year ago

Possibly with the ellipsis, but since all the OSs which the app runs on, Windows, macOS, iOS and Android, use this ellipsis character instead of three periods, I just thought it would be nicely consistent with the OS displays.

Like the 3/4 space spaces or the single character for ℃, these things are invisible to anyone not looking for them.

For people like me they just jump out, probably also because that's what also did to make a living ;)

1technophile commented 1 year ago

Thanks for the PR