theengs / app

Theengs mobile application to read BLE sensors and push data to an MQTT broker
https://app.theengs.io
GNU General Public License v3.0
37 stars 7 forks source link

Black-listed and deleted devices are back in the list with next search for new sensors #64

Closed DigiH closed 1 year ago

DigiH commented 1 year ago

Blacklisted and deleted devices are back in the list with next search for new sensors, even when the device is still listed as black-listed in the device browser.

Verified on iOS and macOS

Also the heading and text for white-listing a device in the device browser again is confusingly talking about black-listing - i.e. same strings as for initial black-listing - only the button has now changed to Whitelist.

Screenshot 2023-02-06 at 21 15 57
emericg commented 1 year ago

Indeed it wasn't working for the devices without MAC, it is now fixed. I improved the popup too.

DigiH commented 1 year ago

Verified with latest macOS build, the functionality is fixed, thanks, but for the whitelisting again the description text still talks about the blacklisting functionality …

Screenshot 2023-02-07 at 19 57 46
emericg commented 1 year ago

Yeah sure, I didn't see a particular need to change the description, but we can put whatever wording you want here.

DigiH commented 1 year ago

Whatever you want and think is appropriate when a user is in the middle of whitelisting a device again, possibly without mentioning "You can un-blacklist the sensor at any time" and "… nothing will happen unless you delete it from the sensor list.".