search

theengs / app

Theengs mobile application to read BLE sensors and push data to an MQTT broker
https://app.theengs.io
GNU General Public License v3.0
37 stars 7 forks source link

Incluson of external probe property for TH-1/TH-2 needs widget/registration adjustment #65

Open DigiH opened 1 year ago

DigiH commented 1 year ago

With the inclusion of the external probe property for TH-1/TH-2 my TH-1 is now displayed only as a generic device with the latest macOS build (also not seeming to update its values), while the iOS app 1.2 (with previous old decoder) still shows it with the correct Thermometer widget.

I'm also not sure if and how the pool thermometer P01B, which is included in the same decoder, and only has temperature, but not humidity, is being displayed in general in the app.

Current latest macOS

Screenshot 2023-02-09 at 14 29 12 Screenshot 2023-02-09 at 14 29 17

iOS 1.2

IMG_1932

IMG_1933

emericg commented 1 year ago

I guess the problem is that the sensor has changed name if Theengs decoder 1.0.

You can see how sensors are assigned to a "device category" using their names here: https://github.com/theengs/app/blob/development/src/DeviceManager_theengs.cpp#L228

And for the rest of the sensors, they can be assigned a category depending on the properties found (but in the absence of clear rules regarding these decisions, it is quite shaky at the moment): https://github.com/theengs/app/blob/development/src/devices/device_theengs_generic.cpp#L115

Also there are many sensors that just doesn't fit in any category (I mean there is a smart dryer...) and that makes these decisions all the more complex. And that why we have "generic" devices now.