search

theeugenechong / pe

0 stars 0 forks source link

DG - Deletion in sequence diagram #10

Open theeugenechong opened 2 years ago

theeugenechong commented 2 years ago

All diagrams have the lifeline extend longer than the deletion symbol. While I know that this is a limitation of PlantUML, I believe that it should have been stated somewhere in the DG (similar to AB3) as it may be misleading to readers

image.png

nus-se-bot commented 2 years ago

Team's Response

Diagram is inherited.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Lifeline extends beyond termination in DG sequence diagram

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.

The sequence diagram under 'Architecture', 'Interactions between components' has a lifeline extending beyond the termination of the object.

image.png

[original: nus-cs2113-AY2122S1/pe-interim#874] [original labels: severity.Low type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Cosmetic related.

PlantUML limitation. It does limit the perception of the diagram.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: As I mentioned in the issue description, this is not really a problem involving the cosmetics of the diagram but rather the lack of documentation to explain the PlantUML limitations to the reader, which in my opinion, may lead to confusion.

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: There is a lack of documentation to explain the flaw in the diagrams which are due to PlantUML limitations (beyond the developers' control).