search

theexidge / routinger

Routinger is a task scheduler app that is made to make you a better person at no extra cost. The code is open-source. Dart language and Flutter framework are used extensively.
GNU Affero General Public License v3.0
27 stars 22 forks source link

Dark mode added #19

Closed bayush-9 closed 3 years ago

bayush-9 commented 3 years ago

I have added dark mode in the app. Please suggest colors as you wish so I will do the edits. I don't have a good color sense. I am dropping screenshots for reference. Screenshot_1633091360 Screenshot_1633091362 Screenshot_1633091364

Kushalrock commented 3 years ago

There should be no color other than blackish-grey, as described in the blog and white color with varying levels of opacity. The top title should have 80% white opacity while body titles should have 70% opacity and so on. Please follow android guidelines and the blog I gave you for reference. @bayush-9

Kushalrock commented 3 years ago

@bayush-9 Please let us know about your status??

Kushalrock commented 3 years ago

@bayush-9 I haven't received any communications from your side

bayush-9 commented 3 years ago

@Kushalrock I will start working on the colors this weekend. I'll keep the inputs in mind.

Kushalrock commented 3 years ago

Sure, I am looking forward towards it. @AyoubBoulahtar will be the one presiding over this PRs decision. As he is the one who knows more about it.

Looking forward to your amazing changes

bayush-9 commented 3 years ago

Just guide me over the colors please. I am a noob in those. :-(

Kushalrock commented 3 years ago

Just guide me over the colors please. I am a noob in those. :-(

Bayush, I can't really spoon feed you. Check these blogs it will help you.

Just for general purposes

"Dark theme - Material Design" https://material.io/design/color/dark-theme.html#ui-application

This is a good one

"The Ultimate Guide on Designing a Dark Theme for your Android app. | by Chethan KVS | Prototypr" https://blog.prototypr.io/how-to-design-a-dark-theme-for-your-android-app-3daeb264637

Use blackish grey and not pure black for base color that's one thing which may be ambiguous.

bayush-9 commented 3 years ago

Yeah okay

AyoubBoulahtar commented 3 years ago

We will need the feature done by Monday, so if you could accelerate a little bit so we can be able to push to master before the deadline.

bayush-9 commented 3 years ago

Screenshot_1633618026 Screenshot_1633618029 Screenshot_1633618032 Screenshot_1633618037 Screenshot_1633618041 Screenshot_1633618045

Please review the colors. Inputs on color changes are welcome.

@AyoubBoulahtar @Kushalrock Please review.

Kushalrock commented 3 years ago

@bayush-9 Sorry, for the delay but I am waiting for a review by @AyoubBoulahtar. I am not exactly the guy who can comment on color schemes. Anything he decides will be final.

AyoubBoulahtar commented 3 years ago

I approve this color palette, although I would prefer the background to not be fully black, maybe some blakish lighter shade. Otherwise you can refactor your code and we can push it to master tomorrow.

bayush-9 commented 3 years ago

@AyoubBoulahtar Now the color is same as mentioned in the blog " #121212 ". Also the theme.dart file is not required now. Moreover I haven't deleted it in these commits for your reference.

AyoubBoulahtar commented 3 years ago

Your changes have been approved, thank you for your contribution.