Closed GrbavaCigla closed 2 years ago
Thank you @GrbavaCigla. I will check the changes out in a few hours and let you know.
@GrbavaCigla I checked your changes, I like them. Yes, that's a wonderful suggestion of shifting from hardcore values to values made in the config file. I will post an issue.
Your folder structure is a bit off. I like your way of organizing, but that leaves most files as-is. But we want to surely try it. If you have some kind of reasoning of why you want that folder structure to be this way, please I would like to hear it. Also, the person whom I assigned the folder structure did let me know that he can't continue. So, if you comment there I will assign it to you. I don't quite know why you have made a main.yaml file and after reading the main.yaml file, it makes little sense. So, if you can provide some more info on that.
Overall a great job. After, I have assigned you to the issue of folder structure, and you provide reasoning for that folder structure, I will close your folder PR.
Regarding your question, is that welcome? Yes, we are very grateful to you.
Your folder structure is a bit off
Yes, i didn't know what to do with remaining files so I left them there. I was hoping you would tell me where to put them.
I don't quite know why you have made a main.yaml file and after reading the main.yaml file, it makes little sense. So, if you can provide some more info on that.
I added main.yaml
for github actions. On every push, it will run and build the app, so if you have an error somewhere, you will know earlier. Also solves "It works on my machine" problems.
Yes, that's a wonderful suggestion of shifting from hardcore values to values made in the config file. I will post an issue.
Can I add that to this PR too? Restructuring folders is too easy and I like to be challenged :D
I have made a new issue, you can comment on that and also on folder structure issue. I will assign them both to you
I organized remaining files by screens and replaced hardcoded values for borderRadius
. Since there are multiple values for borderRadius
, I set it to 8.0
.
@GrbavaCigla Please take a look at the changes requested.
Done, folders are now grouped by screens
@GrbavaCigla Just a few changes Move taskslists folder inside home and make a stats folder inside home to keep stats related stuff.
And for now we wouldn't need GitHub workflows, so yes delete those files but I am thinking of setting it up. I will make an issue, and assign it to you.
@GrbavaCigla I just saw the workflow setup you made, I am genuinely impressed, I would love to have someone on board with the DevOps skillset. If you choose to accept. I just want it to make into a separate issue titled something like GitHub workflow setup and then you commit this workflow with another PR and close that issue. I will make it right away after merging your PR.
@GrbavaCigla Can we chat over Twitter or some other medium about other topics that we need to integrate? After you make the desired changes and I merge the PRs. I will invite you as a member of the organization. If you accept.
I just saw the workflow setup you made, I am genuinely impressed, I would love to have someone on board with the DevOps skillset. If you choose to accept.
Thanks, I accept :D
Can we chat over Twitter or some other medium about other topics that we need to integrate?
Sure, but I don't have twitter. Maybe discord or telegram?
I don't use telegram that often. We can surely use Discord My id is kushalrock #3920
Solves #20
Also, may I propose some changes? I would like to replace hardcoded values for
borderRadius
and similar fields with constants. I will make this PR a draft because I would like to get your opinion on this.Edit: I also found a typo in imports, automated github action could prevent that, is that welcome?