theextremeprogrammer / Succinct

UI tests at the speed of unit tests. Proper encapsulation. Architecture agnostic. Freedom to refactor.
MIT License
42 stars 7 forks source link

Tapping multiple bar button items #42

Closed immenor closed 5 years ago

immenor commented 5 years ago

I took a first pass at adding the ability to tap multiple bar button items in the navigation bar. I also added the ability to tap them based on either the title or the system item. In my case I had two icons in the rightBarButtonItems I needed to tap.

Im not sure if there are rules I should be aware of with the comments above the public functions. I tried to follow the style you had for the tapBarButtonItem(systemItem:) function. Let me know how this works.

codecov-io commented 5 years ago

Codecov Report

Merging #42 into master will increase coverage by <.01%. The diff coverage is 98.62%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #42      +/-   ##
=========================================
+ Coverage   97.39%   97.4%   +<.01%     
=========================================
  Files         126     126              
  Lines        5879    5966      +87     
=========================================
+ Hits         5726    5811      +85     
- Misses        153     155       +2
Impacted Files Coverage Δ
...wController/UIViewController+UIBarButtonItem.swift 100% <100%> (ø) :arrow_up:
...rastructure/Builders/UIViewControllerBuilder.swift 100% <100%> (ø) :arrow_up:
...troller/UIViewController+UIBarButtonItemSpec.swift 99.13% <98.19%> (-0.87%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c2b3581...f063255. Read the comment docs.

theextremeprogrammer commented 5 years ago

Thanks for this PR @immenor! From a quick glance everything looked good - I may tweak a couple of things and then follow up with you afterwards. Thanks again!! 👍

theextremeprogrammer commented 5 years ago

@immenor please take a look at commit 526dd972ca9e7ab1e2a0a5e9e138a4fc6506a00d to see updates made related to this PR and let me know if you want to chat about any of these. 👍 Thanks for bringing this functionality into Succinct!

theextremeprogrammer commented 5 years ago

Closes #41