Finds views inside of the view controller's navigation item title view

[immenor]

I found that the navigationItem property on UIViewController is different than the one on the navigationController itself, and in order for my own tests using a custom titleView to pass with Succinct, I needed to check the navigationItem.titleView directly from the view controller. Therefore, I added a new case to the ViewController extension to check the navigationItem's titleView as well.

Since this is on the UIViewController class I made the guess that this would be the right place to put it.

Since the titleView stuff I wrote previously wasn't accomplishing what I needed, perhaps I should delete the titleView logic from the UINavigationController+UILabel part? Let me know your thoughts.

[codecov-io]

Codecov Report

Merging #6 into master will increase coverage by 0.06%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
+ Coverage   96.73%   96.79%   +0.06%     
==========================================
  Files          96       96              
  Lines        4169     4248      +79     
==========================================
+ Hits         4033     4112      +79     
  Misses        136      136

Impacted Files	Coverage Δ
...ccinctTests/Builders/UIViewControllerBuilder.swift	100% <100%> (ø)	:arrow_up:
...ct/UIViewController/UIViewController+UILabel.swift	100% <100%> (ø)	:arrow_up:
...IViewController/UIViewController+UILabelSpec.swift	100% <100%> (ø)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 581cd27...bf30ae9. Read the comment docs.

[theextremeprogrammer]

Thanks for the PR @immenor!

Since this is on the UIViewController class I made the guess that this would be the right place to put it.

At a glance this looks good to me - since there are tests this can always be refactored afterwards. 👍

Since the titleView stuff I wrote previously wasn't accomplishing what I needed, perhaps I should delete the titleView logic from the UINavigationController+UILabel part? Let me know your thoughts.

The logic you wrote previously is covered in tests so I think it should be fine for now. Maybe it'll be helpful in another scenario? Let's leave it in for now and see how things go.