search

theextremeprogrammer / Succinct

UI tests at the speed of unit tests. Proper encapsulation. Architecture agnostic. Freedom to refactor.
MIT License
42 stars 7 forks source link

Correct names of methods for finding text views containing text with attributes #64

Closed wrightak closed 3 years ago

codecov-io commented 3 years ago

Codecov Report

Merging #64 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #64   +/-   ##
=======================================
  Coverage   97.33%   97.33%           
=======================================
  Files         138      138           
  Lines        5137     5137           
=======================================
  Hits         5000     5000           
  Misses        137      137
Impacted Files Coverage Δ
Succinct/UIView/UIView+UITextView.swift 86.53% <100.00%> (ø)
...UIViewController/UIViewController+UITextView.swift 100.00% <100.00%> (ø)
...ewController/UIViewController+UITextViewSpec.swift 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d6e6436...c8af737. Read the comment docs.

theextremeprogrammer commented 3 years ago

Thanks for this @wrightak! It took me a minute in going through the changes but I think I see what happened here - with UILabel I was distinguishing between when the entire string matches exactly versus when just searching for a partial match. Seems that this was a bit confusing and that confusion found its way in to these methods (that I believe @immenor had added originally).

If you have any other thoughts on making this less confusing please feel free to share! 👍

I'll merge this in now and tag a new release in the next day or two. Thanks again!

immenor commented 3 years ago

Yeah in following the naming convention I didn't name it correctly to match the exact functionality. Thanks @wrightak for noticing this.

theextremeprogrammer commented 3 years ago

Sorry for the delay in getting this release tagged - there were some issues updating the Xcode12 with Carthage that needed to be fixed, and I wanted to get the jazzy documentation issues resolved as well since this was making the build look like it was failing.

I think I've got everything resolved now so you should be able to update to the latest version to pull those changes in. Thanks for your patience!