thefakequake / pypartpicker

A Python package that can be used to fetch information from PCPartPicker on products and parts lists.
MIT License
18 stars 8 forks source link

rate limiter? #16

Closed not-NEKO closed 1 year ago

not-NEKO commented 1 year ago

idk if it works but it should be better to manage rate limiters (i also corrected a little typo). Also i didn't do anything about that but it should be fine to add proxy compatibility. It's easy so i can do that if you want me to.

thefakequake commented 1 year ago

The lib already has proxy compatibility, if you pass in response_retriever when you instantiate Scraper, I think you could also implement your own rate limit solution there as well.

thefakequake commented 1 year ago

I'll accept this PR if you could update the README.md file to add the wait parameter to the docs, thanks.