thefakequake / pypartpicker

A Python package that can be used to fetch information from PCPartPicker on products and parts lists.
MIT License
18 stars 8 forks source link

Why is part_search limited to 20 items? #2

Closed AseCoder closed 3 years ago

AseCoder commented 3 years ago

When searching for parts and trying to set the limit higher than 20, it defaults to 20. Why? Is this a PCPP TOS limitation? What happens if the max limit is increased?

thefakequake commented 3 years ago

At the moment, it is limited to 20 items because that is how many products appear on one search page. I will add functionality to make it so that more products can be fetched by scraping multiple search pages, but for now it is limited to one page. I will close this issue when this is resolved.

AseCoder commented 3 years ago

I understand.

thefakequake commented 3 years ago

This issue has been fixed with v1.2. You can now use a limit of above 20 and it will return more items. Make sure to update your module with pip install --upgrade pypartpicker.