search

thefifthmatt / windmill-client

Build and play puzzles based on the puzzle logic of The Witness
Apache License 2.0
94 stars 12 forks source link

Scale tetris pieces consistently. #27

Closed ianh closed 8 years ago

ianh commented 8 years ago

Track a maximum size across all tetris pieces on the board. This lets us draw all the pieces at the same scale, making puzzles more legible.

gracenotes commented 8 years ago

Thanks! By any chance, does this change the rendering behavior to be closer the game? If so, this is pretty noncontroversial, otherwise also probably great but I would also love to see an example or two of where it really helps.

ianh commented 8 years ago

Yeah, I'm not sure how much the game uses large tetris pieces, but the rendering does seem to be closer: tetris

ianh commented 8 years ago

Oh yeah, and here's the reason I wrote the patch. I was playing around with tetris pieces with gaps between them and found that it looked very messy, with pieces at different sizes: screen shot 2016-03-27 at 23 55 26

Here's what that looks like after the patch: screen shot 2016-03-27 at 23 55 30

ianh commented 8 years ago

Style nits are fine! I should really configure my editor properly instead of fixing up the indentation by hand…