search

thefinn93 / ansible-letsencrypt

An ansible role to generate TLS certificates and get them signed by Let's Encrypt
GNU General Public License v3.0
440 stars 122 forks source link

allow renew command args #27

Closed ryanpineo closed 8 years ago

ryanpineo commented 8 years ago

for example, restart a web server after renewal using hooks. See https://github.com/letsencrypt/letsencrypt/pull/2729/files

thefinn93 commented 8 years ago

omg hooks are a thing!? That's awesome, been waiting for that one for quite some time. Could you add a bit to the README about the new variable, maybe with an example for a common use case (eg reload nginx)? After that I'd be happy to merge

thefinn93 commented 8 years ago

Actually, went and read through the thing a bit more. I feel like it might be more appropriate to break it into 3 variables, to allow separately setting the pre, post and renew hooks. What do you think?

ryanpineo commented 8 years ago

My reasoning for just using an argument variable instead of 1 for each hook was just because it was easier and didn't seem to take anything away. Also puts less of a maintenance burden on this project if any other arguments are added in the future.

Will also add some docs to the README

ryanpineo commented 8 years ago

I can also change the variable in to 3 variables, 1 for each hook, if you think that would be nicer.

thefinn93 commented 8 years ago

Meh that works.

ryanpineo commented 8 years ago

haha alright, cheers :)