Update letsencrypt command

thefinn93 / ansible-letsencrypt

An ansible role to generate TLS certificates and get them signed by Let's Encrypt

GNU General Public License v3.0

442 stars 122 forks source link

Update letsencrypt command #39

Closed Pamplemousse closed 7 years ago

Pamplemousse commented 8 years ago

Fix #30

remove domains from main letsencrypt_command
one command per domain: better granularity and control over which certs exists or not to be generated

thefinn93 commented 8 years ago

Let's Encrypt has a pretty low ratelimit on certs per second level domain. For this reason, I would rather allow and encourage SANs instead of individual certificates

auzias commented 8 years ago

@thefinn93 a few days after your comments, letsencrypt updated its rate limits (up to 20 Certificates per Registered Domain per week).

I guess then that this fork could be considered to be pulled (once the conflict are resolved). I happen to encounter the same need, due to the same usage restriction.

thefinn93 commented 8 years ago

I would consider merging this regardless of the Let's Encrypt ratelimit as long as it's opt-in. Like, just have a boolean that enables it.

rfleschenberg commented 7 years ago

+1 for making it opt-in, I'm concerned it could break existing setups.

thefinn93 commented 7 years ago

Closing this for now, feel free to re-open when it's opt-in.