search

thefinn93 / ansible-letsencrypt

An ansible role to generate TLS certificates and get them signed by Let's Encrypt
GNU General Public License v3.0
440 stars 122 forks source link

add support for specifying explicit standalone authentication arguments #40

Closed beda42 closed 7 years ago

beda42 commented 7 years ago

Hi, I used the ansible-letsencrypt role (thanks) to convert an HTTP only website to HTTPS. During this, I had to use the standalone authentication method and nginx was already listening on 80, so I needed to tell certbot to only use 443 (otherwise it tried both and failed). I did this by adding an extra variable for arguments which are passed directly to the standalone authentication command. I believe others may find this patch useful as well.

Best regards Beda

beda42 commented 7 years ago

Hi again, I just found out that I missed adding the default value for the new argument. I have fixed it in f8e5df7. In case you would like to accept the suggested new feature, please let me know if you would like this pull request removed and a new added or if you will deal with it yourself.

Beda

thefinn93 commented 7 years ago

:+1: looks good!