search

thefinn93 / ansible-letsencrypt

An ansible role to generate TLS certificates and get them signed by Let's Encrypt
GNU General Public License v3.0
440 stars 122 forks source link

issue #52: add six to pip install #53

Open mariojmdavid opened 7 years ago

mariojmdavid commented 7 years ago

seems we need to pip install also six

thefinn93 commented 7 years ago

What environment are you needing this in? Does it break other existing environments? I'd rather not go installing/upgrading any more global packages than I absolutely have to

mariojmdavid commented 7 years ago

hi, I agree with you but here is what happened, the ansible client host is a VM with centos7 (from the official centos7 cloud image) with updates plus the following packages epel-release, ansible git wget python-pip net-tools bind-utils openssl-devel gcc python-devel

after that I pulled the ansible role to my desktop, and run the playbook in issue#52, and obtained the error exception there as I said I solved the issue by adding six to the task of pip in the role, didn't dig much more at that time and the task should run in the python virtualenv for the letsencrypt, after this running the playbook went fine.

what I think should have happened would be that when the pip task installs/upgrades setuptools it should have installed six in that virtualenv because setuptools depends on it (this I just confirmed in a bare centos7 docker - install python-pip and after doing pip install -U setuptools, before six was not in the pip list, and after it was properly from that dep)

anyway I will check again in another VM, best Mario

mariojmdavid commented 7 years ago

hi I tested again using a centos7 VM, just with updates and epel-release the first time I run the playbook, it fails in the issue#52, but running a second time it goes until the end not too nice but not impeditive, and since my test of adding "six" I was running the playbook a second time it's possible it does not solve the issue after all feel free to discard this pull request maybe be worth a second look so the playbook runs good at first run best Mario