search

thefinn93 / ansible-letsencrypt

An ansible role to generate TLS certificates and get them signed by Let's Encrypt
GNU General Public License v3.0
442 stars 122 forks source link

use the certbot package from jessie-backports on debian #59

Closed ArcolaJasper closed 7 years ago

ArcolaJasper commented 7 years ago

only tested with Debian Jessie, but does get certs etc for me.

rfleschenberg commented 7 years ago

Merging https://github.com/ArcolaJasper/ansible-letsencrypt/pull/1 should update this PR so that Debian Stretch is supported. I ran a quick test against a fresh Stretch box.

thefinn93 commented 7 years ago 
  - name: check for Debian != jessie
    fail:
      msg: "Only the jessie release of Debian is supported at the moment"
when: ansible_distribution == "Debian" and ansible_distribution_release != "jessie"

Perhaps we could not refuse to run on non-jessie versions of Debian? Jessie isn't even the stable version anymore. Maybe just run the notdebian.yml in that case

ArcolaJasper commented 7 years ago

Ah, sorry, I miss read the PR from @rfleschenberg as being against thefinn93/ansible-letsencrypt rather than my copy. Let me just check it and merge it and then update this PR.

ArcolaJasper commented 7 years ago

Ok, That add stretch support and will fall back to using pip on non-debian systems.

thefinn93 commented 7 years ago

Cool, looks good, thanks!