search

thefinn93 / ansible-letsencrypt

An ansible role to generate TLS certificates and get them signed by Let's Encrypt
GNU General Public License v3.0
440 stars 122 forks source link

virtualenv conditional #9

Open thefinn93 opened 8 years ago

thefinn93 commented 8 years ago

Installation of the virtualenv package doesn't work on older OSs (older than Debian jessie or Ubuntu Vivid), but on newer OSs need it over python-virtualenv (see #6). We should improve the conditional to reflect this nuance.

pmackay commented 8 years ago

I'd like to get this role working on Ubuntu 14.04. Would https://github.com/pmackay/ansible-letsencrypt/commit/e47e38914856b6e3e67fe29ec87b06b6423b9947 be ok to do a PR? Not sure if this generalizes the solution enough though.

thefinn93 commented 8 years ago

eh i guess. Not ideal but whatever. Maybe someone will come along and fix it all one day...

pmackay commented 8 years ago

Do you happen to know of any matrix that lists all the distributions and versions? And a simple way to determine the right package for each? Or is it a case of trial and error testing or looking up for each one?

pmackay commented 8 years ago

I've done a more generalized approach here https://github.com/pmackay/ansible-letsencrypt/commit/f0d33e7fdfdce2e668bfb0fa8bae5c7e8264a4dc. Does that seem OK?

Have also created a travis-test branch that sets up testing the role on Travis, which I could also raise a PR for if that sounds useful?

thefinn93 commented 8 years ago

PR the travis branch for sure! I'm wrapping of my last quarter of university so I'm gonna be focusing on finals for a bit, I'll take a look at the other thing sometime next week

pmackay commented 8 years ago

Have created #34, feedback welcome whenever is convenient.