Verify it works with all plugins

ekohl commented 2 years ago

At least foreman_dlm does something extra that's not captured yet: precompile the assets in a production environment: https://github.com/dm-drogeriemarkt/foreman_dlm/blob/56af16ae462e5216054473432826cfa235ff26e3/.github/workflows/ci.yml#L77-L84

It also uses nick-fields/retry@v2 to retry failing tests.

ekohl commented 2 years ago

Another thing that is missing is the caching only step on push. This would be to just install the gems, which builds a cache. If that's done when pushing to master, all PRs can benefit the cache. Otherwise the cache is stored in the PR owners repo.

ekohl commented 2 years ago

Another note to self:

NPM caching: https://github.com/actions/setup-node#caching-packages-dependencies
Only install npm if package.json exists

ofedoren commented 2 years ago

Just to update plugins list: https://github.com/theforeman/foreman_webhooks

ekohl commented 2 years ago

Thanks. I found the list by doing ls ~/dev/foreman_*/.github/workflows so it looks like locally I don't have it checked out.

ekohl commented 2 years ago

More notes to self: github.head_ref is only available in the PR context, not on push.

ekohl commented 2 years ago

REX also has:

      - name: 'Upload logs'
        uses: actions/upload-artifact@v2
        if: failure()
        with:
          name: logs
          path: log/*.log
          retention-days: 5

ekohl commented 10 months ago

foreman_ansible has the same log upload and also has rake webpack:compile.

archanaserver commented 8 months ago

https://github.com/theforeman/foreman_salt/pull/192

ekohl commented 8 months ago

In light of https://community.theforeman.org/t/convert-foreman-plugins-continuous-integration-to-github-actions/35917 I've expanded the list with all plugins shipped in Satellite and those currently testing in Jenkins. It already included all plugins that had previous actions.