theforeman / actions

Shared GitHub workflows for use in the Foreman project
3 stars 7 forks source link

always execute access_permissions_test from Foreman core #16

Open evgeni opened 1 year ago

evgeni commented 1 year ago

So, we could have a test:things_plugins_need_to_test_from_core_and_naming_is_hard that lists access_permissions and test:$plugin depends on that (essentially, what openscap is doing plus an dependency)?

the other linked things are good own tests (as in: they are testing that the routes done by the plugin are sane), but I think executing the core version of the test also ensure we don't break stuff from core?

ekohl commented 1 year ago

So I found how I tried to solve it in the past: https://github.com/theforeman/foreman-tasks/pull/677/commits/3ad347bd50f416bb7ca346c9bd686386903e6bc7 can be summed up as https://github.com/theforeman/foreman_plugin_template/pull/51

kamils-iRonin commented 9 months ago

I like the idea of having a static list of recommended core tests in the core. I would also run all core tests on merge to master – to make sure that a plugin does not affect the core. Of course, making these core tests optional would still give us some flexibility.