Closed ekohl closed 8 months ago
I'm starting to wonder how to properly install NPM for plugins, as well as how to make sure there is caching in place for it.
That appears to work. Anything else we should do here? Do you want to apply the same matrix style testing of multiple jobs that we apply in core?
That's a good question I have no definitive answer for.
I guess it'd be a good idea to run test:$plugin, assets:precompile[$plugin] and db:seed.
For the later we have a separate job, but Leos' is right we should test both paths, all migrations in one go, and foreman first, then plugin. So maybe those three as a matrix and the current separate one kept separate?
I can't approve since it's my own PR, so let's try this out by me merging it.
This only happens if package.json exists.
Opening, but needs test cases.
foreman_ansible
haspackage.json
, butforeman_expire_hosts
doesn't.