theforeman / actions

Shared GitHub workflows for use in the Foreman project
3 stars 6 forks source link

Archive all_react_app_exports.js #51

Closed MariaAga closed 4 months ago

MariaAga commented 5 months ago

For: https://github.com/theforeman/foreman/pull/10061

MariaAga commented 5 months ago

The "test foreman_plugin.yml / Ruby / test:foreman-tasks" test running for 6 hours is probably not related to this, right?

evgeni commented 4 months ago

I wonder what happens when the file doesn't exist, like on stable branches. We'll find out after theforeman/foreman#10116 is merged, but for now I'd like to wait for that.

https://github.com/actions/upload-artifact says:

    # The desired behavior if no files are found using the provided path.
    # Available Options:
    #   warn: Output a warning but do not fail the action
    #   error: Fail the action with an error message
    #   ignore: Do not output any warnings or errors, the action does not fail
    # Optional. Default is 'warn'
    if-no-files-found:

So I read this as "will work just fine"