Add custom cipher support

theforeman / ansible-foreman_scap_client

GNU General Public License v3.0

4 stars 13 forks source link

Add custom cipher support #18

Closed igramic closed 3 years ago

igramic commented 3 years ago

https://rubygems.org/gems/foreman_scap_client/versions/0.4.7 has option for selecting ciphers.

This pull request:

Adds :ciphers: in configuration file
Creates foreman_scap_client_ciphers variable to select ciphers
Updates README

xprazak2 commented 3 years ago

Awesome work, needs a small change though. foreman_scap_client_ciphers needs to be added into defaults/main.yml so that foreman is able to detect it when importing variables.

Could you also change commit message to "Fixes #30453 - ${description}"? I have created a redmine ticket to keep track of this feature.

igramic commented 3 years ago

@xprazak2 variable is added and condition is changed. Let me know if anything else is needed

xprazak2 commented 3 years ago

Thanks, it will need one small change though. Ansible/python adds special escaping to strings in array:

ciphers-result

{{ foreman_scap_client_ciphers | to_json }} removes the escaping for me.

xprazak2 commented 3 years ago

I squashed the commits and merged as 3707cb7, thanks!