search

theforeman / ansible-foreman_scap_client

GNU General Public License v3.0
4 stars 14 forks source link

Fixes #29475 - migrate foreman_scap_client_facts.rb script to python #19

Closed snagoor closed 3 years ago

xprazak2 commented 4 years ago

Works nicely, I just left one comment.

snagoor commented 4 years ago

@xprazak2 Fixed all issues based on pylint and it is happy now. Can you please take a look at it again?

$ pylint files/foreman_scap_client_facts.py 

--------------------------------------------------------------------
Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00)
snagoor commented 3 years ago

@xprazak2 can you please take a look at it.

xprazak2 commented 3 years ago

Apologies it takes me so long, it looks good. I'll just give it one more spin to be sure and then I'll merge.

xprazak2 commented 3 years ago

Thanks!