search

theforeman / foreman-ansible-modules

Ansible modules for interacting with the Foreman API and various plugin APIs such as Katello
GNU General Public License v3.0
145 stars 162 forks source link

Community package requirements: sanity tests #1703

Open gotmax23 opened 5 months ago

gotmax23 commented 5 months ago

(Note: This issue was filed in a semi-automated fashion. Let me know if you see errors in this issue.)

As per the Ansible community package inclusion requirements, collections must pass ansible-test sanity tests. Version 3.15.0 of theforeman.foreman, corresponding to the v3.15.0 tag in this repo, fails one or more of the required sanity tests.

Please see the errors below and address them. If these issues aren't addressed within a reasonable time period, the collection may be subject to removal from Ansible.

Thank you for your efforts and for being part of the Ansible package! We appreciate it.

Sanity tests

The following tests were run using ansible-test version 2.16.1:

Note that this is only a subset of the required sanity tests. Please make sure you run them in all in your CI.

Results

💡 NOTE:

See Sanity Tests: Ignores in the dev guide if you believe any of these errors are false positives.

The test ansible-test sanity --test yamllint [explain] failed with 153 errors:

tests/test_playbooks/fixtures/auth_source_ldap-0.yml:302:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/auth_source_ldap-1.yml:17:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/auth_source_ldap-2.yml:382:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/auth_source_ldap-3.yml:382:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/auth_source_ldap-4.yml:17:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/auth_source_ldap-5.yml:17:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/auth_source_ldap-6.yml:17:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/bookmark-0.yml:6276:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/bookmark-1.yml:9:20: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/bookmark-2.yml:9:20: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/bookmark-3.yml:107:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/bookmark-4.yml:107:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/bookmark-5.yml:9:20: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/bookmark-6.yml:9:20: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/compute_attribute-0.yml:151:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/compute_attribute-1.yml:9:20: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/compute_attribute-2.yml:154:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/compute_attribute-3.yml:9:20: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/content_credential-0.yml:225:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/content_credential-1.yml:17:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/content_credential-2.yml:308:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/content_credential-3.yml:17:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/content_credential-4.yml:17:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/content_credential-5.yml:225:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/content_credential-6.yml:17:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/content_credential-7.yml:17:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/content_view_version-0.yml:381:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/content_view_version-1.yml:17:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/content_view_version-2.yml:17:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/content_view_version-3.yml:385:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/content_view_version-4.yml:17:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/content_view_version-5.yml:17:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/content_view_version-6.yml:937:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/content_view_version-7.yml:17:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/content_view_version-8.yml:1087:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/content_view_version-9.yml:17:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/host_power-0.yml:9:20: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/host_power-1.yml:9:20: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/host_power-2.yml:104:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/host_power-3.yml:9:20: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/host_power-4.yml:9:20: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/host_power-5.yml:104:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/host_power-6.yml:9:20: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/host_power-7.yml:9:20: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/image-0.yml:307:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/image-1.yml:17:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/image-2.yml:370:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/image-3.yml:307:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/image-4.yml:17:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/image-5.yml:17:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/image-6.yml:17:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/image-7.yml:17:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/installation_medium-0.yml:257:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/installation_medium-1.yml:9:20: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/installation_medium-10.yml:498:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/installation_medium-11.yml:9:20: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/installation_medium-12.yml:9:20: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/installation_medium-13.yml:9:20: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/installation_medium-2.yml:258:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/installation_medium-3.yml:261:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/installation_medium-4.yml:9:20: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/installation_medium-5.yml:9:20: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/installation_medium-6.yml:220:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/installation_medium-7.yml:261:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/installation_medium-8.yml:9:20: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/installation_medium-9.yml:9:20: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/job_template-0.yml:302:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/job_template-1.yml:17:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/job_template-10.yml:11:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/job_template-11.yml:2988:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/job_template-12.yml:11:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/job_template-13.yml:11:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/job_template-2.yml:398:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/job_template-3.yml:332:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/job_template-4.yml:11:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/job_template-5.yml:11:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/job_template-6.yml:264:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/job_template-7.yml:11:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/job_template-8.yml:11:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/job_template-9.yml:197:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/katello_smart_proxy-0.yml:106:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/katello_smart_proxy-1.yml:12:20: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/katello_smart_proxy-2.yml:180:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/katello_smart_proxy-3.yml:12:20: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/katello_smart_proxy-4.yml:108:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/katello_smart_proxy-5.yml:12:20: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/katello_smart_proxy-6.yml:12:20: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/katello_smart_proxy-7.yml:12:20: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/os_default_template-0.yml:431:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/os_default_template-1.yml:433:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/os_default_template-2.yml:11:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/os_default_template-3.yml:11:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/os_default_template-4.yml:11:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/os_default_template-5.yml:11:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/os_default_template-6.yml:11:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/os_default_template-7.yml:11:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/provisioning_template-0.yml:378:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/provisioning_template-1.yml:17:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/provisioning_template-10.yml:457:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/provisioning_template-11.yml:457:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/provisioning_template-12.yml:301:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/provisioning_template-13.yml:17:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/provisioning_template-14.yml:17:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/provisioning_template-15.yml:10137:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/provisioning_template-16.yml:17:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/provisioning_template-17.yml:17:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/provisioning_template-18.yml:17:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/provisioning_template-2.yml:17:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/provisioning_template-3.yml:457:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/provisioning_template-4.yml:17:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/provisioning_template-5.yml:378:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/provisioning_template-6.yml:456:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/provisioning_template-7.yml:17:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/provisioning_template-8.yml:17:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/provisioning_template-9.yml:17:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/realm-0.yml:110:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/realm-1.yml:9:20: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/realm-2.yml:9:20: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/realm-3.yml:9:20: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/resource_info-0.yml:17:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/resource_info-1.yml:17:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/resource_info-2.yml:17:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/resource_info-3.yml:17:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/resource_info-4.yml:17:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/resource_info-5.yml:17:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/resource_info-6.yml:17:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/setting-0.yml:110:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/setting-1.yml:9:20: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/setting-2.yml:9:20: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/setting-3.yml:111:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/setting-4.yml:9:20: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/setting-5.yml:115:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/setting-6.yml:9:20: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/setting-7.yml:111:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/setting-8.yml:9:20: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/setting-9.yml:111:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/smart_proxy-0.yml:70:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/smart_proxy-1.yml:12:20: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/smart_proxy-2.yml:12:20: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/smart_proxy-3.yml:12:20: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/usergroup-0.yml:120:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/usergroup-1.yml:11:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/usergroup-10.yml:11:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/usergroup-11.yml:11:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/usergroup-12.yml:11:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/usergroup-2.yml:11:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/usergroup-3.yml:11:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/usergroup-4.yml:120:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/usergroup-5.yml:180:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/usergroup-6.yml:11:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/usergroup-7.yml:11:15: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/usergroup-8.yml:120:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
tests/test_playbooks/fixtures/usergroup-9.yml:428:11: unparsable-with-libyaml: None - could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
mdellweg commented 5 months ago

What can i say... Not every yml file is meant to be a playbook. And these live in the tests directory. For all intents and purpose they are to be considered test data and should not be subject to any linter.

evgeni commented 5 months ago

I agree.

Additionally, these files are not distributed as part of the artifact the we upload to Galaxy. How did you obtain the source that you linted?

gotmax23 commented 5 months ago

Thanks for the quick response! The sources are pulled from the v3.15.0 tag in this repository. We are not using Galaxy artifacts here, as they may be missing files that are needed to run the sanity tests. Individual collections should always be running sanity tests in their upstream CI, so we are mirroring that by checking out the repo contents. If those files should not be linted, then you can add test ignores for them.

evgeni commented 5 months ago

But now you're arguably getting more files than necessary? The fixtures do not belong to the collection and adding ignores for them seems odd (especially as ignores are Ansible version dependant and require updates every time the Ansible version bumps).

Why wouldn't sanity run on the artifact in Galaxy? Doesn't Galaxy run sanity on import anyway?

gotmax23 commented 5 months ago

No, Ansible Galaxy runs a different set of tests on import. ansible-test sanity is designed to be run from a collection's git repository so that's how we do it.

mdellweg commented 5 months ago

And as far as i remember, we run that sanity check. So what's the issue in the first place now?

evgeni commented 5 months ago

We run it from a "cleaned up" collection (make $MANIFEST), while @gotmax23 just cloned the collection and runs it on the plain checkout.

mdellweg commented 5 months ago

I know, because I was part of that design, and we had some good reasons to do it that way. But also to your point: You care about what is in galaxy, so the artifact being uploaded to galaxy should be exactly the thing that needs to pass sanity checks. Testing sanity on something that may or may not be turned into the collection artifact does not sound right to me. It's like the equivalent of transport-layer-security when you should do end-to-end-encryption. We only run the sanity checks in PR's here to prevent surprises when actually trying to upload the artifact. And so we run them on exactly we would uploaded as the next release.

gotmax23 commented 5 months ago

But also to your point: You care about what is in galaxy, so the artifact being uploaded to galaxy should be exactly the thing that needs to pass sanity checks. Testing sanity on something that may or may not be turned into the collection artifact does not sound right to me. It's like the equivalent of transport-layer-security when you should do end-to-end-encryption.

Right, that's something we considered. We took a compromise approach. The script that runs the sanity tests across collections compares the hashes of the files in the collection artifact to those in the git repository. Some collection artifacts entirely exclude the tests/ directory (which includes the sanity ignore ignore files) or have other missing files that preclude running sanity tests. If the script had found files that are present in both the collection artifact and this git repository, those would've been included in the issue text above. I would've liked to also mandate that the collection artifact does not contain extra files that are not included in the git repository, but ansible-galaxy collection build does not honor .gitignore, and a fair amount of collections include linter and pytest caches or other temporary files. Getting collections to build collection artifacts in clean checkouts will be a separate endeavor...

I would consider allowing collections that generate files or do other source preprocessing and don't remove test files from their galaxy artifacts to choose that we run sanity tests from those instead of the git repositories, but that would require some code changes to the antsibull-build sanity-tests script that collects the cross-collection sanity test data for these issues. Thanks for the feedback there.

mdellweg commented 5 months ago

Getting collections to build collection artifacts in clean checkouts will be a separate endeavor...

Let me invite you to have a look at the Makefile here, to see how we always build a clean collection artifact from potentially unclean repository checkouts.