Adding missing dns_proxy and description arguments to domain role

theforeman / foreman-ansible-modules

Ansible modules for interacting with the Foreman API and various plugin APIs such as Katello

GNU General Public License v3.0

145 stars 162 forks source link

Adding missing dns_proxy and description arguments to domain role #1708

Closed sscheib closed 4 months ago

sscheib commented 4 months ago

Despite the role's description stating that description and dns_proxy are being passed to the module call of theforeman.foreman.domain, these attributes are not passed to it.

This PR fixes that by passing both description and dns_proxy to the module call if specified. They will be omitted by default.

sscheib commented 4 months ago

Domain tests seem to be fixed, but I don't understand the issue that is present currently. Could sombody review this and give me a hint where to look? Thanks!

evgeni commented 4 months ago

Domain tests seem to be fixed, but I don't understand the issue that is present currently. Could sombody review this and give me a hint where to look? Thanks!

Ignore that, it's fixed in https://github.com/theforeman/foreman-ansible-modules/pull/1707