search

theforeman / foreman-ansible-modules

Ansible modules for interacting with the Foreman API and various plugin APIs such as Katello
GNU General Public License v3.0
147 stars 164 forks source link

please adjust cvf module examples now that cvfr exists #1714

Closed pcfe closed 7 months ago

pcfe commented 7 months ago
SUMMARY

Thanks for #1709 that helped me understand the change and get something working in the homelab. But I did notice that cvf docs page also needs adjusting of the examples to the 4.0.0 changes.

Since it's a minor change only to make the example work but slightly more work to make the cvf and the cvfr match and doing is better than nagging, I'll make a PR with suggested doc change shortly. :-)

ISSUE TYPE
COLLECTION VERSION
theforeman.foreman 4.0.0
STEPS TO REPRODUCE
  1. read 4.0.0 docs for content_view_filter_rule
  2. read 4.0.0 docs for content_view_filter
  3. try to create a filter and then fill it with rules
EXPECTED RESULTS
  1. the example of cvf should be functional, it is not right now as it still shows parts of the old syntax
  2. doing a dumb copypasta of the cvf plus the cvfr examples would ideally give the user one or more filters filled with one or more rules
ACTUAL RESULTS
  1. cvf rule still includes a package_name line, please remove
  2. the examples for cvfr could be improved if the cvf examples created filters that are needed for the cvfr example to work