theforeman / foreman-ansible-modules

Ansible modules for interacting with the Foreman API and various plugin APIs such as Katello

GNU General Public License v3.0

147 stars 163 forks source link

add support for diff output #444

Closed evgeni closed 4 years ago

evgeni commented 5 years ago

The modules currently don't support ansible's --diff mode that outputs a diff what has changed. It'd be cool it they did. And we should have most of the information available already.

mdellweg commented 5 years ago

Maybe should make this one a milestone.

evgeni commented 5 years ago

Technically yes, on the other side the code changes should be minimal.

evgeni commented 5 years ago

https://github.com/theforeman/foreman-ansible-modules/milestone/3

evgeni commented 4 years ago

487 added basic diff output for many modules, but not for:

foreman_compute_profile
foreman_installation_medium
foreman_job_template
foreman_provisioning_template
foreman_ptable
katello_activation_key
katello_content_view
katello_content_view_filter

as these use ensure_entity multiple times. we could add explicit save params to find_resource and ensure_entity, thus making this less magic in such cases.

also we should add tests

evgeni commented 4 years ago

we now implemented everything for a basic diff support in all modules, closing