theforeman / foreman-ansible-modules

Ansible modules for interacting with the Foreman API and various plugin APIs such as Katello
GNU General Public License v3.0
148 stars 166 forks source link

Remove async options from modules #520

Closed mdellweg closed 4 years ago

mdellweg commented 5 years ago
SUMMARY

Ansible has features to run tasks asynchronous (and later wait for them). I think we should stop supporting that at the module level.

ISSUE TYPE
jwbernin commented 5 years ago

As a consumer of these modules, I have to ask that async support remain at least for the katello_sync module. I have a workflow where I start repo syncs as early as possible, then continue with create lifecycle environments and content views, adding repos to content views, and only then do I "wait" for the repo syncs to complete before publishing CVs. While this saves only a few minutes at best, it does save those few minutes, and if only a single small repo is being enabled/synced, it can be very noticeable.

mdellweg commented 5 years ago

Can you share, how you wait for those syncs, please?

mdellweg commented 5 years ago

@jwbernin would this not cover your usecase: https://docs.ansible.com/ansible/latest/user_guide/playbooks_async.html ?

jwbernin commented 5 years ago

That is exactly how I have my workflow configured now. If this methodology doesn't require async support from these modules, I retract my comment.

sean797 commented 5 years ago

We had a similar conversation in https://github.com/theforeman/foreman-ansible-modules/pull/73 when it was first implemented. I'm happy to remove this and rely on https://docs.ansible.com/ansible/latest/user_guide/playbooks_async.html

evgeni commented 5 years ago

I don't use async in my playbooks, so fine for me as long as the Ansible way still works.

evgeni commented 4 years ago

triage: remove, add a link to the ansible docs, done :)