search

theforeman / foreman-ansible-modules

Ansible modules for interacting with the Foreman API and various plugin APIs such as Katello
GNU General Public License v3.0
147 stars 163 forks source link

katello_repository is missing param ignore_global_proxy #551

Closed bzehrfuchs closed 4 years ago

bzehrfuchs commented 4 years ago
SUMMARY

Looking at https://theforeman.org/plugins/katello/3.13/api/apidoc/v2/repositories/create.html, we're missing the parameter _ignore_globalproxy when creating repositories.

Foreman/Satellite uses a global proxy configuration to sync content from the internet, there are also internal repositories which should sync to Foreman/Satellite. Since this internal repos are only reachable from the internal network and not from the proxy the ignore_global_proxy parameter is required.

ISSUE TYPE
ANSIBLE VERSION
KATELLO/FOREMAN VERSION
APYPIE VERSION
STEPS TO REPRODUCE
EXPECTED RESULTS
ACTUAL RESULTS
evgeni commented 4 years ago

FWIW this was marked as deprecated in Katello 3.13 in favor of a more generic http_proxy_policy.

On the one hand I'd prefer not to add deprecated options, on the other we strive to support not only the latest Katello release here, so I'm undecided.

See https://github.com/Katello/katello/commit/579d6b4e767b1b87d57737bfe934a77b9170ef32 and https://projects.theforeman.org/issues/27199

evgeni commented 4 years ago

triage says we can add it and mark it directly as deprecated so that users are warned.

tervor commented 4 years ago

Any progress on this? I have the need to set this for some repos I configure using this ansible modules.