search

theforeman / foreman-ansible-modules

Ansible modules for interacting with the Foreman API and various plugin APIs such as Katello
GNU General Public License v3.0
147 stars 163 forks source link

Split katello_sync module #83

Closed mdellweg closed 5 years ago

mdellweg commented 6 years ago

The discussion in #78 lead to the consensus that we want to split the katello_sync module into katello_product_sync and katello_repository_sync to have overall consistent naming.

Secondary goal: Use module_utils to keep the code duplication small.

itewk commented 6 years ago

coming from katello module I don't see how I can sync a product without also specifying a repository, and that is annoying

itewk commented 6 years ago

nevermind. doc is just wrong.

https://github.com/theforeman/foreman-ansible-modules/blob/master/modules/katello_sync.py#L51 says repositories is required but in reality it is not (https://github.com/theforeman/foreman-ansible-modules/blob/master/modules/katello_sync.py#L150)

mdellweg commented 5 years ago

Is this still a thing? I think, at least the documentation here has been improved by #241 .

sean797 commented 5 years ago

IMO - no, I'd :-1: this

mdellweg commented 5 years ago

BTW: I think the secondary goal is met. :desert: :camel:

mdellweg commented 5 years ago

Given that there were no objections, i am going to close this one.