Ensure RHEL 8 AppStream repo is enabled

theforeman / foreman-documentation

Documentation for the Foreman Project and its ecosystem

https://docs.theforeman.org

Creative Commons Attribution Share Alike 4.0 International

22 stars 95 forks source link

Ensure RHEL 8 AppStream repo is enabled #3297

Closed Lennonka closed 2 months ago

Lennonka commented 2 months ago

What changes are you introducing?

Satellite users must ensure that the repo containing Leapp packages is enabled.

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

https://issues.redhat.com/browse/SAT-27995

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Checklists

[x] I am okay with my commits getting squashed when you merge this PR.
[x] I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

[x] Foreman 3.12/Katello 4.14 (Satellite 6.16)
[ ] Foreman 3.11/Katello 4.13
[ ] Foreman 3.10/Katello 4.12
[ ] Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
[ ] Foreman 3.8/Katello 4.10
[ ] Foreman 3.7/Katello 4.9 (Satellite 6.14)
[ ] Foreman 3.6/Katello 4.8
[ ] Foreman 3.5/Katello 4.7 (Satellite 6.13; orcharhino 6.6/6.7)
We do not accept PRs for Foreman older than 3.5.

github-actions[bot] commented 2 months ago

The PR preview for 5c2684c6866f1dc70cbc4c4f49fbdba37cc57b71 is available at theforeman-foreman-documentation-preview-pr-3297.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

evgeni commented 2 months ago

You can't install Satellite without AppStream repo enabled, so I don't see how this situation could arise.

Lennonka commented 2 months ago

@maximiliankolb @evgeni This was mentioned in the bug report:

After Satellite has been deployed, there are multiple users who unregister the Satellite machine from CDN, or disable the needed repos and enable the unwanted repos on Satellite. Without ensuring that 'rhel-8-for-x86_64-appstream-rpms' repository is enabled on Satellite, may lead to failure in installation of leapp package

Lennonka commented 2 months ago

Then perhaps it should be a prerequisite?

maximiliankolb commented 2 months ago

@maximiliankolb @evgeni This was mentioned in the bug report:

After Satellite has been deployed, there are multiple users who unregister the Satellite machine from CDN, or disable the needed repos and enable the unwanted repos on Satellite. Without ensuring that 'rhel-8-for-x86_64-appstream-rpms' repository is enabled on Satellite, may lead to failure in installation of leapp package

I am neither speaking for orcharhino nor RH support, but IMHO this is clearly not something users should do: Yes, if you play around and remove access to content on your production system, things break. :shrug:

The only thing I could imagine is a note at the end of the installation guides to not remove access to repositories.

evgeni commented 2 months ago

@maximiliankolb @evgeni This was mentioned in the bug report:

After Satellite has been deployed, there are multiple users who unregister the Satellite machine from CDN, or disable the needed repos and enable the unwanted repos on Satellite. Without ensuring that 'rhel-8-for-x86_64-appstream-rpms' repository is enabled on Satellite, may lead to failure in installation of leapp package

This logic also applies to BaseOS then. And the fact that you can't enable a repo if your system is unregistered. (= the step you added would fail if the above bug description is actually performed by a user).

I don't think that every document should re-iterate all prerequisites to have a non-broken system. (the system w/o repos is broken)

Lennonka commented 2 months ago

Alrighty then.