theforeman / foreman-documentation

Documentation for the Foreman Project and its ecosystem
https://docs.theforeman.org
Creative Commons Attribution Share Alike 4.0 International
22 stars 95 forks source link

Modularize managing packages #3339

Closed maximiliankolb closed 1 month ago

maximiliankolb commented 1 month ago

What changes are you introducing?

make the content of the "Managing packages" chapter modular + minor changes to reflect the Foreman/Katello 3.11+ WebUI

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

docs have to be modular to use it downstream.

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Checklists

Please cherry-pick my commits into:

github-actions[bot] commented 1 month ago

The PR preview for b4212c0345180b6aab372bbe131d4d3fdb11acb1 is available at theforeman-foreman-documentation-preview-pr-3339.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

maximiliankolb commented 1 month ago

Any idea if we want to keep "json" for syntax highlighting?

Are there any technical reasons to keep it? Afaik this is the only example:

$ rg --no-filename "^\[" | rg -i json | rg -v "^\[id"
[options="nowrap", json, subs="+quotes,verbatim,attributes"]
apinnick commented 1 month ago

@maximiliankolb

Now I understand that you are showing the output of a query. You're referring to 'snip_managing-packages-api.adoc`, right?

No, I do not see any point in using 'json'. Most output is fine as [source,text], IMO.

I would add a $ to the curl command in the preceding code block, however.

Any idea if we want to keep "json" for syntax highlighting? Are there any technical reasons to keep it? Afaik this is the only example:

$ rg --no-filename "^\[" | rg -i json | rg -v "^\[id"
[options="nowrap", json, subs="+quotes,verbatim,attributes"]
maximiliankolb commented 1 month ago

Yes, I was trying to show that "json" syntax highlighting does not work; implying that we could drop it. For now, I'd keep it as is. I would create a follow-up issue/PR if I see a reason to change that.

maximiliankolb commented 1 month ago

Merged to "master" and cherry-picked: 0bc035b62e..3cf1298d5e 3.12 -> 3.12 0373afcb6d..6298998ee8 3.11 -> 3.11