Use upstream terminology - Githubissues

theforeman / foreman-documentation

Documentation for the Foreman Project and its ecosystem

https://docs.theforeman.org

Creative Commons Attribution Share Alike 4.0 International

22 stars 95 forks source link

Use upstream terminology #3351

Closed maximiliankolb closed 1 month ago

maximiliankolb commented 1 month ago

What changes are you introducing?

Use attributes in favor of hardcoded branded variable names.

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

Fixes branding issues upstream+downstream.

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Checklists

[x] I am okay with my commits getting squashed when you merge this PR.
[x] I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

[x] Foreman 3.12/Katello 4.14 (Satellite 6.16)
[x] Foreman 3.11/Katello 4.13
[ ] Foreman 3.10/Katello 4.12
[ ] Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
[ ] Foreman 3.8/Katello 4.10
[ ] Foreman 3.7/Katello 4.9 (Satellite 6.14)
[ ] Foreman 3.6/Katello 4.8
[ ] Foreman 3.5/Katello 4.7 (Satellite 6.13; orcharhino 6.6/6.7)
We do not accept PRs for Foreman older than 3.5.

github-actions[bot] commented 1 month ago

The PR preview for e91118d617a68f779af4fdf42e128a4f08ceec88 is available at theforeman-foreman-documentation-preview-pr-3351.surge.sh

The following output files are affected by this PR:

show diff as HTML

maximiliankolb commented 1 month ago

Merged to "master" and cherry-picked: 2378756ccf..9bd717ad49 3.12 -> 3.12

Did not cherry-pick to 3.11 because a) one file is not even present and b) build fails due to a missing attribute.