theforeman / foreman-documentation

Documentation for the Foreman Project and its ecosystem
https://docs.theforeman.org
Creative Commons Attribution Share Alike 4.0 International
22 stars 95 forks source link

Add PostgreSQL space requirement in prerequisites #3357

Closed AkshayGadhaveRH closed 1 month ago

AkshayGadhaveRH commented 1 month ago

As PostgreSQL is upgraded from 12 to 13 during the upgrade process, it is necessary to maintain enough space for this. Adding this as a prerequisite to the upgrade.

Ref: https://github.com/theforeman/foreman_maintain/blob/master/definitions/checks/disk/available_space_postgresql13.rb

JIRA: https://issues.redhat.com/browse/SAT-28667

What changes are you introducing?

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Checklists

Please cherry-pick my commits into:

github-actions[bot] commented 1 month ago

The PR preview for 5ad1024b0375ac8a2a9fa742f2112c366b928b5b is available at theforeman-foreman-documentation-preview-pr-3357.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

asteflova commented 1 month ago

Looking at the comment in https://github.com/theforeman/foreman-documentation/pull/3357/files/ae505f817e93a84552f4538c87ef59d7aad4e133#r1792231647, I think Ashish might have simply misread the line but to be fair, "same amount" and "some amount" are very similar and this could happen to users too.

While the new bullet point explains the actual requirement, it doesn't explain the context. (What PostgreSQL upgrade? Why does PostgreSQL need upgrading? When does it happen? Should I be the one to perform the upgrade?) I'm not suggesting that all these questions need to be answered -- that would be too many words for a simple prerequisite. But adding just a little bit more detail about what is happening during the upgrade would help prevent users from asking these questions in the first place.

More importantly, the related release notes (upstream and downstream) mention that users can delete /var/lib/pgsql/data-old/ after the upgrade completes. If this is valid, then I'd recommend including it as a step in the upgrade procedure.

apinnick commented 1 month ago

@AkshayGadhaveRH Rebasing should fix the Vale problem.

Lennonka commented 1 month ago

Cherry picked: