search

theforeman / foreman-documentation

Documentation for the Foreman Project and its ecosystem
https://docs.theforeman.org
Creative Commons Attribution Share Alike 4.0 International
22 stars 95 forks source link

Mention that the external database should be upgraded #3374

Closed AkshayGadhaveRH closed 1 month ago

AkshayGadhaveRH commented 1 month ago

The external database should be upgraded from PostgreSQL 12 to 13. Mentioning this in the ext DB upgrade chapter.

JIRA: https://issues.redhat.com/browse/SAT-28273

What changes are you introducing?

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Checklists

Please cherry-pick my commits into:

github-actions[bot] commented 1 month ago

The PR preview for aa0714ce00696094a2afdd7e3471c3ddb5591e8b is available at theforeman-foreman-documentation-preview-pr-3374.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

AkshayGadhaveRH commented 1 month ago

@Lennonka agreed. Makes sense to me.

Lennonka commented 1 month ago

I've set both "review done" labels because it's correct that PG 13 is needed for 3.12/6.16 and I have reviewed the style as well.

asteflova commented 1 month ago

I don't think it's a good idea to set tech review done without an actual technical review. This is a new feature that deserves a closer look from Engineering. Also, the latest comment in https://issues.redhat.com/browse/SAT-28273 suggests that there is additional context to consider. I'm unsetting the tech review done label again. (IMHO docs people should not provide tech review for significant updates or new features, that's why we have two separate types of review.)

@AkshayGadhaveRH please work with the Platform team to secure a proper technical review.

AkshayGadhaveRH commented 1 month ago

@evgeni does this plan look good? (also, small question for you)

  1. The documentation should mention that the EL version of the DB should be the same as that of the Satellite.
  2. We should mention that the postgresql version should be upgraded for EL8.

Will this involve creating backup of old (pgsql12 + RHEL 8) and restoring that on fresh (pgsql13 + EL8)?

  1. The external DB upgrade chapter should talk about EL8 to EL9 upgrade of the external DB OS. RHEL9 already has postgresql by default.

_Edit existing proc_upgrading-the-external-database.adoc module._

evgeni commented 1 month ago
  1. The OS should be updated, but it's not necessary for the upgrade of the main server.
  2. The PostgreSQLmust be upgraded to 13, which is mandatory for the upgrade of the server.
  3. We don't document how these upgrades are to be done, that's up to the local admin.
Lennonka commented 1 month ago

Looks good to me.

@evgeni Do we have a technical ack?

AkshayGadhaveRH commented 1 month ago

@Lennonka @evgeni is this good to go?

asteflova commented 1 month ago

Merged to "master" and cherry-picked: