theforeman / foreman-documentation

Documentation for the Foreman Project and its ecosystem
https://docs.theforeman.org
Creative Commons Attribution Share Alike 4.0 International
22 stars 95 forks source link

Update links to RHEL docs #3429

Closed rh-max closed 2 weeks ago

rh-max commented 2 weeks ago

What changes are you introducing?

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

Fixing broken links to RHEL docs found by linkchecker.

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Checklists

Please cherry-pick my commits into:

github-actions[bot] commented 2 weeks ago

The PR preview for 8f4294a365ac901f7e9e05eb8d1a432f07f28e76 is available at theforeman-foreman-documentation-preview-pr-3429.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

rh-max commented 2 weeks ago

@maximiliankolb Hi Max, could you PTAL at the Salt repo updated links? I'm not sure every accompanying text is fitting the new link. Thanks. https://github.com/theforeman/foreman-documentation/pull/3429/commits/641935741a67821c92dcdac4b0f1d6ddf747f385

rh-max commented 2 weeks ago

Thanks for reviews Lena & Aneta. I've set the cherrypicks for all supported versions, please let me know if that's incorrect.

asteflova commented 2 weeks ago

Thanks for reviews Lena & Aneta. I've set the cherrypicks for all supported versions, please let me know if that's incorrect.

Yes, it's a good idea to try to fix the links in all branches, thanks for that. From peeking at the changes you're making, I also expect conflicts on some of those branches. Not a problem now, of course, I'm just sharing that to manage expectations :)

@rh-max Have you noticed the deploy / build-html check failure? Let me know if you'd like help with troubleshooting.

asteflova commented 2 weeks ago

Meanwhile, I've done a bit of a label maintenance, setting tech review done (because this kind of link change doesn't IMO need tech review) and style review needed (because there is no peer review ack yet). This is a fairly recent addition to contributing guidelines and the exact workflow definition is still work in progress in case you'd like to contribute with your feedback @rh-max

asteflova commented 2 weeks ago

https://github.com/theforeman/foreman-documentation/pull/3411 addressed the linkchecker errors related to Salt. I'm leaving the re-review to @Lennonka.

Lennonka commented 2 weeks ago

Cherry picked:

@rh-max There are conflicts on 3.10. Please, file another PR for older branches.

asteflova commented 2 weeks ago

@Lennonka It looks like this didn't get cherry-picked into 3.13. Can you please look into it?

Lennonka commented 2 weeks ago

@asteflova Thank you for the reminder! CP'd to 3.13 and comment above updated.