hide "dnf needs-restarting" on Satellite, foreman-maintain does hint - Githubissues

theforeman / foreman-documentation

Documentation for the Foreman Project and its ecosystem

https://docs.theforeman.org

Creative Commons Attribution Share Alike 4.0 International

22 stars 95 forks source link

hide "dnf needs-restarting" on Satellite, foreman-maintain does hint #3432

Closed evgeni closed 2 weeks ago

evgeni commented 2 weeks ago

What changes are you introducing?

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Checklists

[x] I am okay with my commits getting squashed when you merge this PR.
[x] I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

[x] Foreman 3.12/Katello 4.14 (Satellite 6.16)
[ ] Foreman 3.11/Katello 4.13 (orcharhino 6.11 on EL8 only)
[ ] Foreman 3.10/Katello 4.12
[ ] Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
[ ] Foreman 3.8/Katello 4.10
[ ] Foreman 3.7/Katello 4.9 (Satellite 6.14)
[ ] Foreman 3.6/Katello 4.8
[ ] Foreman 3.5/Katello 4.7 (Satellite 6.13; orcharhino 6.6/6.7)
We do not accept PRs for Foreman older than 3.5.

github-actions[bot] commented 2 weeks ago

The PR preview for a0a27ab26c86a8c73dca6ff27e211c4adc7d0689 is available at theforeman-foreman-documentation-preview-pr-3432.surge.sh

The following output files are affected by this PR:

show diff as HTML

ekohl commented 2 weeks ago

Adding context: https://github.com/theforeman/foreman_maintain/commit/6640166fa416d0f67f0152475b3eaaa065875d83 introduced the check in foreman_maintain which should already tell the user if they need to reboot.

asteflova commented 2 weeks ago

I'll take Ewoud's comment above as a tech ack so let's go ahead and merge.

asteflova commented 2 weeks ago

Merged to "master" and cherry-picked:

942948ef6e..8c13f00047 3.13 -> 3.13 0404660b48..3ed1f10155 3.12 -> 3.12